feat: (Core) Custom Messages in pickers #4361
Conversation
JKMarkowski
changed the title
|
✔️ Deploy preview for fundamental-ngx ready! 🔨 Explore the source changes: 3662074 🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-ngx/deploys/600558a6b5edd60008f5a3d9 😎 Browse the preview: https://deploy-preview-4361--fundamental-ngx.netlify.app |
|
Deploy preview for fundamental-ngx ready! Built with commit 26efdc3 |
| get state(): FormStates { | ||
| return this._state; | ||
| } | ||
| private _state: FormStates = null; |
There was a problem hiding this comment.
missing typedocs and @hidden for _state
| @ViewChild(CalendarComponent) | ||
| calendarComponent: CalendarComponent<D>; | ||
|
|
||
| @ViewChild('inputGroupComponent', { read: ElementRef }) |
| @@ -218,6 +240,19 @@ export class DatePickerComponent<D> implements OnInit, OnDestroy, ControlValueAc | |||
| @Output() | |||
| readonly activeViewChange: EventEmitter<FdCalendarView> = new EventEmitter<FdCalendarView>(); | |||
|
|
|||
| /** @hidden */ | |||
| @ViewChild(CalendarComponent) | |||
| calendarComponent: CalendarComponent<D>; | |||
There was a problem hiding this comment.
should be prefixed with _
| /** @hidden The value of the input */ | ||
| inputFieldDate: string = null; | ||
|
|
||
| /** @hidden Whether the date input is invalid */ | ||
| isInvalidDateInput = false; |
There was a problem hiding this comment.
Should be prefixed with _ since it's hidden?
| get state(): FormStates { | ||
| return this._state; | ||
| } | ||
|
|
||
| private _state: FormStates = null; |
There was a problem hiding this comment.
same as above, missing typedocs and hidden
| @@ -247,6 +280,10 @@ export class DatetimePickerComponent<D> implements OnInit, OnDestroy, OnChanges, | |||
| @ViewChild(CalendarComponent) | |||
| _calendarComponent: CalendarComponent<D>; | |||
|
|
|||
| /** @hidden */ | |||
| @ViewChild('inputGroupComponent', { read: ElementRef }) | |||
| inputGroupElement: ElementRef; | |||
| @@ -8,3 +8,7 @@ | |||
| max-width: 100%; | |||
| } | |||
| } | |||
|
|
|||
| .invisible { | |||
There was a problem hiding this comment.
I think it should have some sort of prefix, o.w. can conflict with the same class in the application
There was a problem hiding this comment.
It's not used anywhere, so I will just remove
|
Thanks @InnaAtanasova for review, your comments are applied |
JKMarkowski
force-pushed
the
feat/2934-custom-messages
branch
from
1f4f11a
to
222abb0
Compare
Please provide a link to the associated issue.
closes: #2934
Please provide a brief summary of this pull request.
There is added new way to add messages into date/time/datetimepicker.
messageInput into them.I created new popover-form service, that can be reused in other form components in future.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md