Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (Core) Quick View title's corners and added ability to align title #4418

Merged
merged 2 commits into from
Jan 25, 2021
Merged

fix: (Core) Quick View title's corners and added ability to align title #4418

merged 2 commits into from
Jan 25, 2021

Conversation

artolshansky
Copy link
Contributor

Note: issue with title gaps resolved here SAP/fundamental-styles#2069

Please provide a link to the associated issue.

Closes: #4406
Related: #4400

Please provide a brief summary of this pull request.

Please check whether the PR fulfills the following requirements

Documentation checklist:

  • Documentation Examples
  • Stackblitz works for all examples

@artolshansky artolshansky added bug Something isn't working core Core library specific issues labels Jan 20, 2021
@artolshansky artolshansky added this to the Sprint 55 - ariba milestone Jan 20, 2021
@artolshansky artolshansky requested review from puru-hk and a team January 20, 2021 13:38
@artolshansky artolshansky self-assigned this Jan 20, 2021
@netlify
Copy link

netlify bot commented Jan 20, 2021 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit f1cf4cd

https://deploy-preview-4418--fundamental-ngx.netlify.app

This was referenced Jan 21, 2021
Closed
Closed
@puru-hk
Copy link
Contributor

puru-hk commented Jan 21, 2021

Tested these issues . it is working as expected.
#4406
#4400

@puru-hk puru-hk closed this Jan 21, 2021
@puru-hk puru-hk reopened this Jan 21, 2021
@JKMarkowski
Copy link
Contributor

JKMarkowski commented Jan 21, 2021 •
edited

@olshansky Code looks good to me, but is this(title - employee) done on purpose?
image

@artolshansky
Copy link
Contributor Author

@olshansky Code looks good to me, but is this(title - employee) done on purpose?

@JKMarkowski I've mentioned it here in the first line of PR's description 🙃

Note: issue with title gaps resolved here SAP/fundamental-styles#2069

@InnaAtanasova InnaAtanasova changed the title fix: (Core) Quick View title`s corners and added ability to align title fix: (Core) Quick View title's corners and added ability to align title Jan 22, 2021
@InnaAtanasova
Copy link
Contributor

@olshansky Code looks good to me, but is this(title - employee) done on purpose?

@JKMarkowski I've mentioned it here in the first line of PR's description 🙃

Note: issue with title gaps resolved here SAP/fundamental-styles#2069

Trust me, no one is reading the PR description :D saying this from experience :D

InnaAtanasova
InnaAtanasova reviewed Jan 22, 2021
View reviewed changes
libs/core/src/lib/quick-view/quick-view-title/quick-view-title.component.ts Outdated

@Component({
selector: 'fd-quick-view-title',
templateUrl: './quick-view-title.component.html',
changeDetection: ChangeDetectionStrategy.OnPush
})
export class QuickViewTitleComponent {}
export class QuickViewTitleComponent {
/** Alignment of title. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add to the typedocs the text:
Options include 'left', 'right' and 'middle'. The default is set to 'middle'.

Thank you!

@artolshansky artolshansky merged commit ccb727b into main Jan 25, 2021
@artolshansky artolshansky deleted the fix/quick-view-title branch January 25, 2021 09:36
@manjunathanagaraj manjunathanagaraj mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilAlexei EvilAlexei EvilAlexei approved these changes

@Betrozov Betrozov Betrozov approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@puru-hk puru-hk Awaiting requested review from puru-hk

Assignees

@artolshansky artolshansky

Labels
bug Something isn't working core Core library specific issues
Projects
None yet
Milestone
Sprint 55 - ariba
Development

Successfully merging this pull request may close these issues.

Quick View: Point and edges of the popover is not proper
6 participants
@artolshansky @puru-hk @JKMarkowski @InnaAtanasova @EvilAlexei @Betrozov