fix: (Platform) fix combobox examples for stackblitz #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betrozov
added
documentation
28 tasks
|
Deploy preview for fundamental-ngx ready! Built with commit 6289ebf |
artolshansky
approved these changes
Jan 25, 2021
| @@ -89,7 +84,7 @@ export class ComboboxComponent extends BaseCombobox implements OnInit, AfterView | |||
|
|
|||
| /** @hidden */ | |||
| ngOnInit(): void { | |||
| const providers = this.providers.size === 0 ? this._comboboxConfig.providers : this.providers; | |||
| const providers = this.providers && this.providers.size === 0 ? this._comboboxConfig.providers : this.providers; | |||
There was a problem hiding this comment.
Since we a using TS greater than 3.7 it could be simplified:
Suggested change
| const providers = this.providers && this.providers.size === 0 ? this._comboboxConfig.providers : this.providers; | |
| const providers = this.providers?.size === 0 ? this._comboboxConfig.providers : this.providers; |
InnaAtanasova
requested changes
Jan 25, 2021
fkolar
approved these changes
Jan 25, 2021
Betrozov
changed the title
Betrozov
force-pushed
the
fix-combobox-stackblitz
branch
from
c331207
to
6289ebf
Compare
InnaAtanasova
approved these changes
Jan 25, 2021
4 tasks
artolshansky
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Part of #4392
Please provide a brief summary of this pull request.
All Combobox examples work on StackBlitz
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist: