Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (Platform) fix StackBlitz examples part 2 #4484

Merged
merged 8 commits into from
Feb 2, 2021
Merged

fix: (Platform) fix StackBlitz examples part 2 #4484

merged 8 commits into from
Feb 2, 2021

Conversation

Betrozov
Copy link
Contributor

Please provide a link to the associated issue.

#4392
Fixed StackBlitz examples:

  • Date Picker
  • Datetime Picker
  • Info Label
  • Object Status
  • Thumbnail
  • Time Picker

Please check whether the PR fulfills the following requirements

Documentation checklist:

  • Documentation Examples
  • Stackblitz works for all examples

@Betrozov Betrozov added documentation There is an issue with documentation platform platform stackblitz labels Jan 26, 2021
@Betrozov Betrozov added this to the Sprint 55 - ariba milestone Jan 26, 2021
@Betrozov Betrozov self-assigned this Jan 26, 2021
@Betrozov Betrozov mentioned this pull request Jan 26, 2021
Closed
28 tasks
@netlify
Copy link

netlify bot commented Jan 26, 2021 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit f150c1d

https://deploy-preview-4484--fundamental-ngx.netlify.app

@JKMarkowski
Copy link
Contributor

JKMarkowski commented Jan 28, 2021 •
edited

I found issues with pickers, but this also occurs in core examples and only in stackblitz - I checked test application and everything is ok, so I don't think there is a way to make it work

  • DatePicker - opnening/closing
    image

  • DateTimePicker/TimePicker - Hamerjs doesn't seem to be working
    Peek 2021-01-28 12-06

  • Also Thumbnails -something wrong with protocols I guess
    image

@Betrozov
Copy link
Contributor Author

  • Also Thumbnails -something wrong with protocols I guess
    image

Hi @JKMarkowski
Looks like I fixed it.
Can you recheck, please?

JKMarkowski
JKMarkowski approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, As we discussed there is no way to reproduce pickers issues in any other environment, so we can just leave it.

@manjunathanagaraj manjunathanagaraj mentioned this pull request Jan 29, 2021
Closed
@Betrozov Betrozov force-pushed the fix-stackblitz-examples-v2 branch 2 times, most recently from fd17399 to 12f069f Compare February 2, 2021 12:55
@Betrozov Betrozov merged commit 45a52de into main Feb 2, 2021
@Betrozov Betrozov deleted the fix-stackblitz-examples-v2 branch February 2, 2021 17:08
@droshev droshev mentioned this pull request May 11, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@JKMarkowski JKMarkowski JKMarkowski approved these changes

@KevinOkamoto KevinOkamoto KevinOkamoto approved these changes

Assignees

@Betrozov Betrozov

Labels
documentation There is an issue with documentation platform platform stackblitz
Projects
None yet
Milestone
Sprint 56 - ariba
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Betrozov @JKMarkowski @mikerodonnell89 @KevinOkamoto @manjunathanagaraj