fix: (Core) add fix for keeping the focus on the button for Carousel component #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Deploy preview for fundamental-ngx ready! Built with commit 1cd5886 |
DeepakSap14
reviewed
Jan 27, 2021
| @@ -377,6 +381,7 @@ export class CarouselComponent implements OnInit, AfterContentInit, AfterViewIni | |||
| * It works only if carousel is not in circular loop. | |||
| */ | |||
| private _preventDefaultBtnFocus(): void { | |||
| console.log('asdsad'); | |||
There was a problem hiding this comment.
@DeepakSap14 Thanks for noticing it :)
DeepakSap14
approved these changes
Jan 27, 2021
InnaAtanasova
approved these changes
Jan 27, 2021
InnaAtanasova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
part of #4482
Please provide a brief summary of this pull request.
Before:
After:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md