fix: (Core) set is-disabled class to disabled button

[artolshansky]

Please provide a link to the associated issue.

Part of #4391

Please provide a brief summary of this pull request.

Set is-disabled class to disabled or aria-disabled="true" buttons.

Please check whether the PR fulfills the following requirements

• the commit message follows the guideline:
  https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
• tests for the changes that have been done
• all items on the PR Review Checklist are addressed :
  https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist

Documentation checklist:

• [n/a] update README.md
• [n/a] Breaking Changes Wiki
• Documentation Examples
• Stackblitz works for all examples

Note:

Don't understand why, but this test case not working on the default test case. That's why I've added a new test case.

    it('should add is-disabled class to disabled button', () => {
        element.setAttribute('disabled', null);
        fixture.detectChanges(); // or componentInstance.ngOnChanges();
        componentInstance.buildComponentCssClass();

        let cssClass = componentInstance.buildComponentCssClass().join(' ');
        expect(cssClass).toContain('is-disabled');

        element.removeAttribute('disabled');
        element.setAttribute('aria-disabled', 'true');
        fixture.detectChanges(); // or componentInstance.ngOnChanges();
        componentInstance.buildComponentCssClass();

        cssClass = componentInstance.buildComponentCssClass().join(' ');
        expect(cssClass).toContain('is-disabled');
    });

[netlify]

Deploy preview for fundamental-ngx ready!

Built with commit 8e0a086

https://deploy-preview-4499--fundamental-ngx.netlify.app

[InnaAtanasova]

#4391 is a Stackblitz issue. Are you sure this is the correct issue you are fixing?

[artolshansky]

#4391 is a Stackblitz issue. Are you sure this is the correct issue you are fixing?

@InnaAtanasova yeah, that is exactly how I've found this issue (in #4391 this issue described like stackblitz example issue, but it is not an example issue, it's a component issue)

[valorkin]

it's fine

[puru-hk]

Tested with the screen reader. It should able to read the disable button

[InnaAtanasova]

#4391 is a Stackblitz issue. Are you sure this is the correct issue you are fixing?

@InnaAtanasova yeah, that is exactly how I've found this issue (in #4391 this issue described like stackblitz example issue, but it is not an example issue, it's a component issue)

thanks for explaining :) I thought it could be a typo.

[artolshansky]

Tested with the screen reader. It should able to read the disable button

@puru-hk Button with disabled attribute should not be in the tab order, that's why reader not able to read button and it's by W3 (e.g. you could check a few most popular website, e.g. ebay)