Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Platform) fix StackBlitz examples part 3 #4512

Merged
merged 10 commits into from
Feb 4, 2021

Conversation

Betrozov
Copy link
Contributor

@Betrozov Betrozov commented Jan 28, 2021

Please provide a link to the associated issue.

#4392
Fixed StackBlitz examples:

  • List
  • Standard List Item
  • Display List Item
  • Object List Item
  • Action List Item
  • Multi Input
  • Value Help Dialog

Is there anything else we should know?

You can check Multi-Input examples on StackBlitz now.
Other examples will be works after publish @fundamental-ngx/platform with these changes

Please check whether the PR fulfills the following requirements

Documentation checklist:

  • Documentation Examples
  • Stackblitz works for all examples

@Betrozov Betrozov added documentation There is an issue with documentation platform platform stackblitz labels Jan 28, 2021
@Betrozov Betrozov added this to the Sprint 55 - ariba milestone Jan 28, 2021
@Betrozov Betrozov self-assigned this Jan 28, 2021
@netlify
Copy link

netlify bot commented Jan 28, 2021

Deploy preview for fundamental-ngx ready!

Built with commit c64ca58

https://deploy-preview-4512--fundamental-ngx.netlify.app

@InnaAtanasova
Copy link
Contributor

Hey @Betrozov the examples for List are failing https://deploy-preview-4512--fundamental-ngx.netlify.app/#/platform/list
Screen Shot 2021-01-29 at 2 13 30 PM

@Betrozov
Copy link
Contributor Author

Hey @Betrozov the examples for List are failing https://deploy-preview-4512--fundamental-ngx.netlify.app/#/platform/list
Screen Shot 2021-01-29 at 2 13 30 PM

Hi @InnaAtanasova
You can check Multi-Input examples on StackBlitz now, other examples will be works after publish @fundamental-ngx/platform with these changes 🙂

@Betrozov Betrozov force-pushed the fix-stackblitz-examples-v3 branch 2 times, most recently from ca7b354 to c9c70ed Compare February 2, 2021 12:55
@Betrozov Betrozov merged commit a83860d into main Feb 4, 2021
@Betrozov Betrozov deleted the fix-stackblitz-examples-v3 branch February 4, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation There is an issue with documentation platform platform stackblitz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants