fix: (Platform) fix tabChange event not emitting in Dynamic Page #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavya-b
added
bug
|
Deploy preview for fundamental-ngx ready! Built with commit bf02533 |
kavya-b
force-pushed
the
fix-dynamic-page-tabchange
branch
from
19cb096
to
4872ae0
Compare
kavya-b
force-pushed
the
fix-dynamic-page-tabchange
branch
from
4872ae0
to
9b4e963
Compare
artolshansky
approved these changes
Feb 2, 2021
kavya-b
force-pushed
the
fix-dynamic-page-tabchange
branch
from
9b4e963
to
6eddb4f
Compare
KevinOkamoto
approved these changes
Feb 2, 2021
kavya-b
force-pushed
the
fix-dynamic-page-tabchange
branch
from
6eddb4f
to
3ed52fc
Compare
- also fix disable header example background inherit on hover - few a11y fixes for disable header example
kavya-b
force-pushed
the
fix-dynamic-page-tabchange
branch
from
3ed52fc
to
bf02533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes #4514
fixes #4495
Please provide a brief summary of this pull request.
Core tab had some breaking changes, where selectedIndexChange was replaced with selectedTabChange. This was not changed in Dynamic Page implementation which uses this output event, due to which the
tabChangeevent was not being emitted. This PR makes the necessary changes. You can see the console.log message appear now when the tab is changed.It also refactors 'disable header' example and fixes a theming related issue for the same example.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md