fix: (Core) remove responsive paddings when Shellbar is used with Side Nav #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 8661969 |
Betrozov
reviewed
Feb 2, 2021
| * When set to true, the responsive paddings are not applied | ||
| */ | ||
| @Input() | ||
| sideNav: boolean = false; |
InnaAtanasova
force-pushed
the
fix/shellbar-with-sidenav
branch
2 times, most recently
from
4188157
to
c1f0c64
Compare
InnaAtanasova
force-pushed
the
fix/shellbar-with-sidenav
branch
from
c1f0c64
to
8661969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
closes #4556
Please provide a brief summary of this pull request.
This PR removes the responsive paddings which are applied based on the screen size so that the control button (hamburger ) is aligned vertically with the icons/text in the Side Nav. This is achieved by introducing a modifier class
fd-shellbar--side-navwhich applies0 0.5rem 0 0paddings on the Shellbar.Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md