fix: (Core) Add token validate function to MultiInput #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 6246937 |
Betrozov
suggested changes
Feb 10, 2021
| } | ||
|
|
||
| validateFunc(value: string): boolean { | ||
| return value && value.length >= 3 |
There was a problem hiding this comment.
Suggested change
| return value && value.length >= 3 | |
| return value?.length >= 3 |
| @@ -481,14 +488,21 @@ export class MultiInputComponent implements | |||
| }); | |||
| } | |||
|
|
|||
| /** @hidden */ | |||
| private defaultDisplay(str: string): string { | |||
| private defaultDisplay(str: string): string { | ||
| return str; | ||
| } | ||
|
|
||
| /** @hidden */ | ||
| private defaultParse(str: string): string { |
| private defaultParse(str: string): string { | ||
| return str; | ||
| } | ||
|
|
||
| /** @hidden */ | ||
| private defaultTokenValidate(str: string): boolean { |
mikerodonnell89
approved these changes
Feb 10, 2021
|
Will be good to merge after addressing @Betrozov 's comments |
|
@Betrozov Thanks for comments, could you recheck it now? |
JKMarkowski
force-pushed
the
fix/multi-input-validate-tokens
branch
from
6116a5d
to
6246937
Compare
droshev
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
part of #4483
Please provide a brief summary of this pull request.
There is added multi input new token validation method.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md