Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (Core) Readonly select and arrow down fix #4631

Merged
merged 1 commit into from
Feb 12, 2021
Merged

fix: (Core) Readonly select and arrow down fix #4631

merged 1 commit into from
Feb 12, 2021

Conversation

JKMarkowski
Copy link
Contributor

Please provide a link to the associated issue.

part of #4483

Please provide a brief summary of this pull request.

there was repeated key down handler in select component

Please check whether the PR fulfills the following requirements

Documentation checklist:

@JKMarkowski JKMarkowski added core Core library specific issues Defect Hunting labels Feb 10, 2021
@JKMarkowski JKMarkowski added this to the Sprint 55 - Monaco milestone Feb 10, 2021
@JKMarkowski JKMarkowski requested a review from a team February 10, 2021 12:35
@JKMarkowski JKMarkowski self-assigned this Feb 10, 2021
@JKMarkowski JKMarkowski added this to In progress in Development via automation Feb 10, 2021
@netlify
Copy link

netlify bot commented Feb 10, 2021 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit 9c11e5e

https://deploy-preview-4631--fundamental-ngx.netlify.app

InnaAtanasova
InnaAtanasova approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is not passing

@droshev droshev merged commit a92d96e into main Feb 12, 2021
Development automation moved this from In progress to Done Feb 12, 2021
@droshev droshev deleted the fix/select-readonly branch February 12, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@JKMarkowski JKMarkowski

Labels
core Core library specific issues Defect Hunting
Projects
No open projects
Development
  
Done
Milestone
Sprint 55 - Monaco
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JKMarkowski @droshev @InnaAtanasova