Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix playground background color #4856

Merged
merged 1 commit into from Mar 13, 2021
Merged

docs: fix playground background color #4856

merged 1 commit into from Mar 13, 2021

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Mar 5, 2021

Please provide a link to the associated issue.

fixes: #3127

@droshev droshev added the documentation There is an issue with documentation label Mar 5, 2021
@droshev droshev added this to the Sprint 57 - Edinburgh milestone Mar 5, 2021
@droshev droshev requested a review from a team March 5, 2021 00:28
@droshev droshev self-assigned this Mar 5, 2021
@droshev droshev added this to In progress in Development via automation Mar 5, 2021
@netlify
Copy link

netlify bot commented Mar 5, 2021 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit ad9be26

https://deploy-preview-4856--fundamental-ngx.netlify.app

@nikvalor
Copy link
Contributor

nikvalor commented Mar 5, 2021 •
edited

Project: null CORE
Url: null
This link will expire at

@nikvalor
Copy link
Contributor

nikvalor commented Mar 5, 2021 •
edited

Project: null Platform B
Url: null
This link will expire at

@nikvalor
Copy link
Contributor

nikvalor commented Mar 5, 2021 •
edited

Project: null Platform A
Url: null
This link will expire at

mikerodonnell89
mikerodonnell89 requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want a white background here?

Screen Shot 2021-03-09 at 2 55 56 PM

@droshev
Copy link
Contributor Author

droshev commented Mar 9, 2021

Don't we want a white background here?

Screen Shot 2021-03-09 at 2 55 56 PM

but in dark themes it doesn't work well

@InnaAtanasova
Copy link
Contributor

Agree with @mikerodonnell89
You can use either transparent or --sapObjectHeader_Background
Screen Shot 2021-03-10 at 11 03 22 AM

@droshev droshev force-pushed the docs/fix-playgroung-bckg-color branch from 0f4678a to ad9be26 Compare March 10, 2021 22:29
@droshev
Copy link
Contributor Author

droshev commented Mar 10, 2021

Agree with @mikerodonnell89
You can use either transparent or --sapObjectHeader_Background
Screen Shot 2021-03-10 at 11 03 22 AM

Even if i don't agree i did it.

@droshev droshev merged commit 3c687ac into main Mar 13, 2021
Development automation moved this from In progress to Done Mar 13, 2021
@droshev droshev deleted the docs/fix-playgroung-bckg-color branch March 13, 2021 15:18
JKMarkowski pushed a commit that referenced this pull request Mar 30, 2021
@droshev @JKMarkowski
docs: fix playground background color #3127 (#4856)
a60c1a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@droshev droshev

Labels
documentation There is an issue with documentation
Projects
No open projects
Development
  
Done
Milestone
Sprint 58 - Stockholm
Development

Successfully merging this pull request may close these issues.

Make our doc site theme-able
4 participants
@droshev @nikvalor @InnaAtanasova @mikerodonnell89