Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Core) Dynamic page init content resize #4886

Merged
merged 1 commit into from Mar 9, 2021

Conversation

JKMarkowski
Copy link
Contributor

Please provide a brief summary of this pull request.

Please check whether the PR fulfills the following requirements

There are some issues in height calculations for content inside dynamic page, when page is being redirected.
Before:
old

After:
new

Documentation checklist:

@JKMarkowski JKMarkowski added core Core library specific issues dxp labels Mar 9, 2021
@JKMarkowski JKMarkowski requested a review from a team March 9, 2021 11:06
@JKMarkowski JKMarkowski self-assigned this Mar 9, 2021
@JKMarkowski JKMarkowski added this to In progress in Development via automation Mar 9, 2021
@netlify
Copy link

netlify bot commented Mar 9, 2021

Deploy preview for fundamental-ngx ready!

Built with commit 2829e0c

https://deploy-preview-4886--fundamental-ngx.netlify.app

@nikvalor
Copy link
Contributor

nikvalor commented Mar 9, 2021

Project: null CORE
Url: null
This link will expire at

@nikvalor
Copy link
Contributor

nikvalor commented Mar 9, 2021

Project: null Platform B
Url: null
This link will expire at

@nikvalor
Copy link
Contributor

nikvalor commented Mar 9, 2021

Project: null Platform A
Url: null
This link will expire at

@JKMarkowski JKMarkowski merged commit edce21f into main Mar 9, 2021
Development automation moved this from In progress to Done Mar 9, 2021
@JKMarkowski JKMarkowski deleted the fix/dynamic-page-init-sizing branch March 9, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues dxp
Projects
No open projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants