Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (Platform) Multi Input add the ability to add an item with Enter #5179

Merged
merged 4 commits into from
Apr 23, 2021
Merged

fix: (Platform) Multi Input add the ability to add an item with Enter #5179

merged 4 commits into from
Apr 23, 2021

Conversation

Betrozov
Copy link
Contributor

Please provide a link to the associated issue.

Fixes #4439
Fixes #4440

Please provide a brief summary of this pull request.

For Multi-Input added the ability to add an item with Enter
Fixed example

Please check whether the PR fulfills the following requirements

Documentation checklist:

@Betrozov Betrozov added the platform platform label Apr 21, 2021
@Betrozov Betrozov added this to the Sprint 60 - Ariba milestone Apr 21, 2021
@Betrozov Betrozov self-assigned this Apr 21, 2021
@netlify
Copy link

netlify bot commented Apr 21, 2021 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit baafe4b

https://deploy-preview-5179--fundamental-ngx.netlify.app

@Betrozov Betrozov requested a review from a team April 22, 2021 12:19
dimamarksman
dimamarksman approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@dimamarksman dimamarksman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

KevinOkamoto
KevinOkamoto approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@KevinOkamoto KevinOkamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@puru-hk
Copy link
Contributor

puru-hk commented Apr 23, 2021

Both these issues is fixed #4439 and #4440
But I have found and issue here
go to https://deploy-preview-5179--fundamental-ngx.netlify.app/#/platform/multi-input
scroll down to the "multi input reactive" example
click on the input field
type "Tenn" and look for autocomplete suggestion
hit the ENTER key
Get the popup "form file Uploaded successfully"
Click on ok still is not selected in input field
Attached the screenshot
Screenshot 2021-04-23 at 17 14 35

@puru-hk
Copy link
Contributor

puru-hk commented Apr 23, 2021

Looks fine

@Betrozov Betrozov merged commit 7347f6c into main Apr 23, 2021
@Betrozov Betrozov deleted the fix-platform-multi-input branch April 23, 2021 15:27
DeepakSap14 pushed a commit that referenced this pull request Apr 26, 2021
@Betrozov @DeepakSap14
fix: (Platform) Multi Input add the ability to add an item with Enter (…
f4a3a28 
…#5179)

* fix: (platform) Multi Input add the ability to add an item with Enter

* docs: (platform) Multi Input selected option always shows null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimamarksman dimamarksman dimamarksman approved these changes

@artolshansky artolshansky artolshansky approved these changes

@puru-hk puru-hk puru-hk approved these changes

@KevinOkamoto KevinOkamoto KevinOkamoto approved these changes

Assignees

@Betrozov Betrozov

Labels
platform platform QA Approved
Projects
None yet
Milestone
Sprint 60 - Ariba
5 participants
@Betrozov @puru-hk @dimamarksman @artolshansky @KevinOkamoto