fix: refactor table to remove custom elements #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattL75
reviewed
Apr 8, 2019
| selector: 'fd-table-body', | ||
| // TODO to be discussed | ||
| // tslint:disable-next-line:component-selector | ||
| selector: '[fd-table-body]', | ||
| templateUrl: './table-body.component.html' | ||
| }) | ||
| export class TableBodyComponent {} |
There was a problem hiding this comment.
I think this will fix the issue good stuff
These components should be directives though, no? Files should be renamed as well in that case
| </thead> | ||
| <ng-content select="fd-table-body"></ng-content> | ||
| <ng-content select="thead"></ng-content> | ||
| <ng-content select="tbody"></ng-content> |
There was a problem hiding this comment.
maybe add an ng-content for custom stuff? might as well
|
as mentioned I think you can remove all the css in the tables scss file |
MattL75
approved these changes
Apr 10, 2019
MattL75
suggested changes
Apr 10, 2019
MattL75
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(possibly) fixes #396
can't reproduce the issue on my machine so we will have to ask around and see if this fixes it.