Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): select - display proper value #7680

Merged
merged 1 commit into from Feb 4, 2022
Merged

Conversation

dmitry-stepanenko
Copy link
Contributor

Related Issue(s)

closes #7616

Description

When selecting option in select, selected value should be displayed as text, instead we have [object Object]

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • [n/a] check Light/Dark/HCB/HCW themes
  • [n/a] RTL/LTR - proper rendering and labeling
  • [n/a] responsiveness(resize)
  • [n/a] Content Density (Cozy/Compact/(Condensed))
  • [n/a] States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • [n/a] Mouse vs. Keyboard support
  • [n/a] Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • [n/a] API boundary values
  • [n/a] different combinations of components - free style
  • [n/a] change the API values during testing
  1. Documentation and Example validations
  • [n/a] missing API documentation or it is not understandable
  • poor examples
  • [n/a] Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@netlify
Copy link

netlify bot commented Feb 4, 2022

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 29be082

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/61fd5bb966f25b0008eb14be

😎 Browse the preview: https://deploy-preview-7680--fundamental-ngx.netlify.app

@droshev droshev merged commit 9bc907f into main Feb 4, 2022
@droshev droshev deleted the ds/7616-select-bug branch February 4, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform Select bug
3 participants