Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): vhd - misc issues #7713

Merged
merged 1 commit into from Feb 11, 2022
Merged

fix(platform): vhd - misc issues #7713

merged 1 commit into from Feb 11, 2022

Conversation

dmitry-stepanenko
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko commented Feb 9, 2022

Related Issue(s)

closes #7615

Description

  • Value help dialog: Ned spacing before search field
    Fundamental-ngx:
    image
    Guideline:
    image

  • Value help dialog: Content densities not match: Multi-input component has cozy, but buttons has compact
    image

  • Value help dialog: unnecessary scrollbar in example:
    image

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • [x ] Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • [n/a] API boundary values
  • [n/a] different combinations of components - free style
  • [n/a] change the API values during testing
  1. Documentation and Example validations
  • [n/a] missing API documentation or it is not understandable
  • [n/a] poor examples
  • [n/a] Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@dmitry-stepanenko dmitry-stepanenko added this to the Sprint 81 - Ariba milestone Feb 9, 2022
@dmitry-stepanenko dmitry-stepanenko self-assigned this Feb 9, 2022
@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: bee98e8

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/620641fa295ecf00073d28d2

😎 Browse the preview: https://deploy-preview-7713--fundamental-ngx.netlify.app/assets/typedoc/platform/classes/tablecolumnresizeservicemock

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit bee98e8):

https://fundamental-ngx-gh--pr7713-ds-7615-vhd-bugs-3ixx3d5c.web.app

(expires Mon, 14 Feb 2022 11:09:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@droshev droshev merged commit b0def36 into main Feb 11, 2022
@droshev droshev deleted the ds/7615-vhd-bugs branch February 11, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform Value Help bugs
4 participants