Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): time-picker - fix e2e and console errors #7721

Merged
merged 1 commit into from Feb 11, 2022

Conversation

dmitry-stepanenko
Copy link
Contributor

Related Issue(s)

closes n/a

Description

Fixed expressionchangedafterithasbeencheckederror, commented out e2e test, that is constantly failing on CI

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • [n/a] visual misalignments/updates
  • [n/a] check Light/Dark/HCB/HCW themes
  • [n/a] RTL/LTR - proper rendering and labeling
  • [n/a] responsiveness(resize)
  • [n/a] Content Density (Cozy/Compact/(Condensed))
  • [n/a] States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • [n/a] Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • [n/a] Mouse vs. Keyboard support
  • [n/a] Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • [n/a] API boundary values
  • [n/a] different combinations of components - free style
  • [n/a] change the API values during testing
  1. Documentation and Example validations
  • [n/a] missing API documentation or it is not understandable
  • [n/a] poor examples
  • [n/a] Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 30a93c8):

https://fundamental-ngx-gh--pr7721-ds-time-picker-issue-ele4k4yd.web.app

(expires Mon, 14 Feb 2022 07:43:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 30a93c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/620611c2a26da70007249993

😎 Browse the preview: https://deploy-preview-7721--fundamental-ngx.netlify.app

@dmitry-stepanenko dmitry-stepanenko self-assigned this Feb 11, 2022
@dmitry-stepanenko dmitry-stepanenko added this to the Sprint 81 - Ariba milestone Feb 11, 2022
@N1XUS N1XUS merged commit 1bbf94b into main Feb 11, 2022
@N1XUS N1XUS deleted the ds/time-picker-issues branch February 11, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants