Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs/core/platform): strict angularCompilerOptions #7998

Merged
merged 7 commits into from
Apr 19, 2022

Conversation

dmitry-stepanenko
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko commented Apr 18, 2022

Related Issue(s)

closes #7563
closes #7565
closes #7564
closes #7526

Description

Enabled strictTemplates & fullTemplateTypeCheck rules in all packages and docs application.

There were some issues that caused this PR to contain the following breaking changes:

  • ListGroupPipe and GroupFunction interface were moved from @fundamental-ngx/core/utils to @fundamental-ngx/core/combobox as it is the only place where it's needed.
  • core-checkbox’s checkedChange output now emits plain value
  • NumberStepInputChangeEvent from @fundamental-ngx/platform/number-step-input has been removed in favour of base StepInputChangeEvent
  • isValidControlState has been moved from @fundamental-ngx/platform/shared to @fundamental-ngx/core/utils
  • FdSelectChange from @fundamental-ngx/core/select has been removed as it was never in use

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • [n/a] responsiveness(resize)
  • [n/a] Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • [n/a] Mouse vs. Keyboard support
  • [n/a] Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • [n/a] API boundary values
  • [n/a] different combinations of components - free style
  • [n/a] change the API values during testing
  1. Documentation and Example validations
  • [n/a] missing API documentation or it is not understandable
  • [n/a] poor examples
  • [n/a] Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@netlify
Copy link

netlify bot commented Apr 18, 2022

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit ec0b381
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/625e7e3a19ac6e0008115a9f
😎 Deploy Preview https://deploy-preview-7998--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/7565-strict-compilation-params branch 3 times, most recently from 5193f12 to a8c3746 Compare April 18, 2022 09:55
@dmitry-stepanenko dmitry-stepanenko changed the title refactor: strict compilation params refactor: strict angularCompilerOptions Apr 18, 2022
@github-actions
Copy link

github-actions bot commented Apr 18, 2022

Visit the preview URL for this PR (updated for commit ec0b381):

https://fundamental-ngx-gh--pr7998-ds-7565-strict-compi-xucvd0h3.web.app

(expires Fri, 22 Apr 2022 09:26:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/7565-strict-compilation-params branch from a8c3746 to 1d7d623 Compare April 18, 2022 11:00
@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/7565-strict-compilation-params branch from a688532 to 10b0ce9 Compare April 18, 2022 13:34
@dmitry-stepanenko dmitry-stepanenko changed the title refactor: strict angularCompilerOptions feat(docs/core/platform): strict angularCompilerOptions Apr 18, 2022
@dmitry-stepanenko dmitry-stepanenko marked this pull request as ready for review April 18, 2022 14:19
@dmitry-stepanenko dmitry-stepanenko requested review from a team April 18, 2022 14:19
Copy link
Contributor

@g-cheishvili g-cheishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was some boyscout development. good job, just take a look at the notes, nothing particurarly important

Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! added to the description some tasks that will be automatically fixed.

libs/core/src/lib/select/select.component.ts Show resolved Hide resolved
@dmitry-stepanenko dmitry-stepanenko merged commit acd8502 into main Apr 19, 2022
@dmitry-stepanenko dmitry-stepanenko deleted the ds/7565-strict-compilation-params branch April 19, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants