-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs/core/platform): strict angularCompilerOptions #7998
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5193f12
to
a8c3746
Compare
Visit the preview URL for this PR (updated for commit ec0b381): https://fundamental-ngx-gh--pr7998-ds-7565-strict-compi-xucvd0h3.web.app (expires Fri, 22 Apr 2022 09:26:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
a8c3746
to
1d7d623
Compare
a688532
to
10b0ce9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was some boyscout development. good job, just take a look at the notes, nothing particurarly important
...dynamic-page-examples/dynamic-page-facets-example/dynamic-page-facets-example.component.html
Show resolved
Hide resolved
apps/docs/src/app/documentation/core-helpers/sections-toolbar/sections-toolbar.component.html
Outdated
Show resolved
Hide resolved
...s/platform-forms/checkbox/platform-checkbox-examples/platform-tristate-checkbox.component.ts
Outdated
Show resolved
Hide resolved
...m-multi-combobox/examples/multi-combobox-states/multi-combobox-states-example.component.html
Show resolved
Hide resolved
libs/platform/src/lib/form/checkbox-group/checkbox-group.component.ts
Outdated
Show resolved
Hide resolved
libs/platform/src/lib/form/form-generator/pipes/get-ordered-form-controls.pipe.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! added to the description some tasks that will be automatically fixed.
Related Issue(s)
closes #7563
closes #7565
closes #7564
closes #7526
Description
Enabled
strictTemplates
&fullTemplateTypeCheck
rules in all packages and docs application.There were some issues that caused this PR to contain the following breaking changes:
ListGroupPipe
andGroupFunction
interface were moved from@fundamental-ngx/core/utils
to@fundamental-ngx/core/combobox
as it is the only place where it's needed.checkedChange
output now emits plain valueNumberStepInputChangeEvent
from@fundamental-ngx/platform/number-step-input
has been removed in favour of baseStepInputChangeEvent
isValidControlState
has been moved from@fundamental-ngx/platform/shared
to@fundamental-ngx/core/utils
FdSelectChange
from@fundamental-ngx/core/select
has been removed as it was never in usePlease check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md