fix: search shellbar position #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit fe6a7ce |
droshev
reviewed
May 31, 2019
| <fd-shellbar-actions [user]="user" | ||
| [userMenu]="userMenu" | ||
| [productSwitcher]="productSwitcher"> | ||
| <button fd-button | ||
| [fdType]="'standard'">Custom Button</button> |
There was a problem hiding this comment.
It is a good to have an example with a custom component inserted in the shellbar
MattL75
reviewed
May 31, 2019
| @@ -0,0 +1,4 @@ | |||
| .fd-search-input--closed .fd-popover__body { | |||
| width: 300px !important; | |||
| left: -264px !important; | |||
There was a problem hiding this comment.
why do we need !important here?
There was a problem hiding this comment.
These styles are normally applied to this class but are overridden by popper.js
There was a problem hiding this comment.
This is very specific and not very responsive
There was a problem hiding this comment.
This is exactly how the component is styled in Fundamental, minus the !important, which is necessary because popper.js is overriding these styles. I think shellbar responsiveness is a larger separate issue
MattL75
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #377
also removes CoPilot and fixes a bug with the search input popover container not displaying correctly in the shellbar