fix: month gets skipped when the current date is the 31st and the user clicks next month button #862
Conversation
|
Deploy preview for fundamental-ngx ready! Built with commit 2c256d2 |
… start of function
| // get the current date of the month | ||
| const currentDate = this.date.getDate(); | ||
| // get the number of days in the new month | ||
| const daysInNewMonth = new Date(this.date.getFullYear(), month + 1, 0).getDate(); |
There was a problem hiding this comment.
if this is december, will the Date object automatically go to January of next year?
There was a problem hiding this comment.
yes
new Date(2019, 12, 1) = Wed Jan 01 2020 00:00:00 GMT-0700 (Mountain Standard Time)
| in the event that the currentDate is 31 and the next month has 30 days | ||
| */ | ||
| if (currentDate > daysInNewMonth) { | ||
| this.date.setDate(1); |
There was a problem hiding this comment.
Does this go to the next month?
There was a problem hiding this comment.
No, it sets the date for the current month to 1, but sets it back later
There was a problem hiding this comment.
hmm not sure how friendly this for ux
There was a problem hiding this comment.
This is all happening internally, not with the actual ngModel the user sees
There was a problem hiding this comment.
Yeah I know, but so if the user is on the 31st and clicks next, it goes to date(1) of the same month that was currently displayed? Or the next month?
There was a problem hiding this comment.
The month that is currently displayed, but I don't think this really matters because it reverts back a few lines later
There was a problem hiding this comment.
Can you describe the PR in the description? And also exactly the flow of the bug? Like for instance, if the user presses the next month button, this and this happens.
There was a problem hiding this comment.
Added a little description. The original ticket is linked in the description with a gif demonstration
|
Why does it skip February if you press next in January 31st? |
It's just the way dates in JS work... if date===jan 31 and you say date.setMonth(feb) it'll skip over Feb and go straight to March. Because there is no Feb 31. You can easily test this bug on master, and the big fix on this branch, by setting a specific selectedDay.date in the calendar-single-example.component.ts example code https://stackoverflow.com/questions/23976513/javascript-setmonth-shows-improper-date |
|
Yeah but I'm saying instead of doing that, why not set it to Feb 1st? |
fixes #855
Fixed bug where if the 31st day of the month is selected and the user clicks the next month button, and the next month has fewer than 31 days, the next month will be skipped and the one after that will be displayed. So for example if Jan 31 is selected and the next month button is clicked, March will be displayed.