fix: Add min-width option on alerts with default value #863
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit a9da69f |
MattL75
suggested changes
Jun 5, 2019
| @@ -14,6 +14,7 @@ export class AlertComponentAsContentExampleComponent { | |||
| openFromComponent() { | |||
| this.alertService.open(AlertContentComponent, { | |||
| type: 'warning', | |||
| minWidth: '400px', | |||
There was a problem hiding this comment.
Maybe just put this one down to 300, even if it's the default. 400px will break on some phone screens which defeats the purpose of this feature. The rest seems pretty good to me though. Eventually we'll want to address #865 but that can wait for now.
There was a problem hiding this comment.
Hi @MattL75 I changed 400px to 300px in example.
MattL75
reviewed
Jun 6, 2019
| @@ -51,6 +51,11 @@ export class AlertService { | |||
| alertConfig.width = '33vw'; | |||
| } | |||
|
|
|||
| // Ensure default minimum width | |||
| if (alertConfig && !alertConfig.minWidth) { | |||
There was a problem hiding this comment.
When your pr #868 is merged you will be able to remove this check 👍
JKMarkowski
force-pushed
the
bug/#645-alert-responsive-improve
branch
from
f61784a
to
a9da69f
Compare
MattL75
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#654
Please provide a brief summary of this pull request.
I included minimum width option to alert component which handles responsive problems. By default right now min-width is set to 300px, which means that it will look good on every device.
If this is a new feature, have you updated the documentation?
I put this option usage into one example