fix: add possibility to include scrollable table + example in docs #869
Conversation
|
Deploy preview for fundamental-ngx ready! Built with commit 998f8ac |
MattL75
changed the title
| templateUrl: './table-docs.component.html', | ||
| styles: [` | ||
| ::ng-deep app-table .fd-tile { | ||
| display: block; |
There was a problem hiding this comment.
hmm kind of annoying that this is needed in the first place, but I get it and it's fine to keep it. Maybe something we can consider improving later
|
This works really good, but I am wondering if we want to test for div width and apply the fixed class to the parent based on that rather than have it as a directive? Could use the scrollbar width changes for frame of reference but this might be something we should check with the fundamental design team |
|
Actually in fiori fundamental library there is no such thing allowing to scroll horizontally. --fixed class is more useful on adding fixed cell, so it's not needed to be used in this case. |
|
Yeah I'm good to merge this - maybe we could add the fixed cell at some point, or even make it toggle-able in the example. I'll wait for word from @mikerodonnell89 though. |
…n docs
Please provide a link to the associated issue.
#704
Please provide a brief summary of this pull request.
I added directive which makes scrolling table horizontally possible.
If this is a new feature, have you updated the documentation?
Yes, the documentation is updated and contains one of usage example.