fix: change list component to directive #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 554c744 |
mikerodonnell89
approved these changes
Jun 12, 2019
MattL75
suggested changes
Jun 12, 2019
There was a problem hiding this comment.
Great work @JKMarkowski!
Could you also make the ListItemComponent into a directive as part of this issue (I'll amend it)? Right now it's being used as a directive but is really a component.
|
Hi @MattL75 I just pushed these changes. |
MattL75
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes #891
Please provide a brief summary of this pull request.
I changed list component to directive and added some test
If this is a new feature, have you updated the documentation?
Updated by itself