Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split public_api #907

Merged
merged 2 commits into from Jun 14, 2019

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Jun 12, 2019

Please provide a link to the associated issue.

fixes #784

Please provide a brief summary of this pull request.

I added index.d.ts file on every single component which exports all required file.

If this is a new feature, have you updated the documentation?

--

@netlify
Copy link

netlify bot commented Jun 12, 2019

Deploy preview for fundamental-ngx ready!

Built with commit ba7e649

https://deploy-preview-907--fundamental-ngx.netlify.com

@MattL75
Copy link
Contributor

MattL75 commented Jun 12, 2019

Good stuff @JKMarkowski!

I think the CI is failing because of the barrel imports. If you import explicitly for example export * from './lib/popover/index.d.ts' it might fix it. We've had issues with barrel imports in libraries in another project before.

@JKMarkowski
Copy link
Contributor Author

I found the information that .d.ts files are already compiled and ready to be used for javascript, we shouldn't name files like that directly. After compilation in dist directory all exported files with .ts extension are being changed to .d.ts. Changing naming did job.

@mikerodonnell89 mikerodonnell89 self-requested a review June 13, 2019 20:48
@droshev droshev added this to the sprint 13 - Hot Pie milestone Jun 14, 2019
@droshev droshev merged commit 0142308 into SAP:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
board
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Split public_api
4 participants