New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add custom formatting to datetime picker #918
fix: add custom formatting to datetime picker #918
Conversation
Deploy preview for fundamental-ngx ready! Built with commit 515c734 |
1a70ff2
to
5b4bd96
Compare
date.getDate() + ' ' + | ||
getAtLeastTwoDigits(date.getHours()) + '/' + | ||
getAtLeastTwoDigits(date.getMinutes()) + '/' + | ||
getAtLeastTwoDigits(date.getSeconds()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would make more sense:
getAtLeastTwoDigits(date.getHours()) + 'h' +
getAtLeastTwoDigits(date.getMinutes()) + 'm' +
getAtLeastTwoDigits(date.getSeconds() + 's');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Time delimiters has been changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Please provide a link to the associated issue.
fixes #804
Please provide a brief summary of this pull request.
I added possibility to put custom formatting for datetime picker
If this is a new feature, have you updated the documentation?
Added 1 example with usage.