Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fd-tree throwing error when used without header #933

Merged
merged 1 commit into from Jun 17, 2019

Conversation

migg24
Copy link
Contributor

@migg24 migg24 commented Jun 14, 2019

Please provide a link to the associated issue.

No issue, found the issue while using fd-tree.

Please provide a brief summary of this pull request.

When using the <fd-tree> without a [header] this part of the code throws errors because this.header is undefined, practically making [header] a mandatory attribute even if you do not need headers (currently you need to provide an empty array).

If this is a new feature, have you updated the documentation?

As a side note the documentation for I could not find on https://sap.github.io/fundamental-ngx/home.

…he code throws errors because this.header is undefined, practically making [header] a mandatory attribute even if you do not need headers (currently you need to provide an empty array).
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Jun 14, 2019

Deploy preview for fundamental-ngx ready!

Built with commit a789754

https://deploy-preview-933--fundamental-ngx.netlify.com

@mikerodonnell89
Copy link
Member

While this is currently a prototype, undocumented component at the moment, we're liking this PR. Thanks @migg24

@mikerodonnell89 mikerodonnell89 self-requested a review June 15, 2019 00:04
@MattL75 MattL75 changed the title Fix: fd-tree throwing error when used without header fix: fd-tree throwing error when used without header Jun 17, 2019
@MattL75 MattL75 merged commit 5ea350f into SAP:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants