feat: add disabled state for datepicker and datetimepicker #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 6a9641c |
MattL75
suggested changes
Jun 19, 2019
There was a problem hiding this comment.
Add unit tests, and also there should be a check in the code about the disabled property when attempting to select a new date.
The disabled property should be controlled by the ControlValueAccessor and through the input.
setDisabledState(isDisabled: boolean): void {
this.disabled = isDisabled;
}This is to enable the form disabled property to work as well.
|
@MattL75 think I got that covered, let me know if I missed anything |
MattL75
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #956