Skip to content

Commit

Permalink
feat: upgrade fundamental-styles to 0.11.0-rc.100 (#1121)
Browse files Browse the repository at this point in the history 
* fix: rc 47, shellbar classnames

* fix: rc 69, table selection styling

* fix: rc 71, remove overlay

* fix: rc 73, cozy

* chore: rc 74, remove product menu

* chore: rc 75, datepicker button icon

* chore: rc 88, snapshots

* feat: rc 89, removing icon sizes, removed classes

* fix: icon size

* chore: rc 93, snapshots

* fix: test

* fix: test

* feat: rc 95 checkbox label ellipsis overflow

* fix: rc 97, select combobox role

* fix: checkbox text fix, select a11y fixes

* fix: simplify props passing

* fix: duplicate id in select and popper

* fix: test validation state overriding focus announcement

* chore: rc 100, storyshots

* fix: remove duplicate checked state

* fix: aria-label Checkbox, select all rows example

* fix: header cell checked

* fix: add back backdropClassName

* fix: select all rows checked

* fix: use rem values

* fix: conditonal style prop
  • Loading branch information
@jacobdevera
jacobdevera committed Jul 14, 2020
1 parent fd03d6f commit 695aac4
Show file tree
Hide file tree
Showing 28 changed files with 4,127 additions and 914 deletions.
6 changes: 3 additions & 3 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"chain-function": "^1.0.1",
"classnames": "^2.2.6",
"detect-browser": "^5.1.0",
"fundamental-styles": "0.11.0-rc.34",
"fundamental-styles": "0.11.0-rc.100",
"keycode": "^2.2.0",
"moment": "^2.26.0",
"prop-types": "^15.7.1",
Expand Down
4 changes: 2 additions & 2 deletions src/DatePicker/DatePicker.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ class DatePicker extends Component {
'fd-bar',
'fd-bar--footer',
{
'fd-bar--cosy': !compact,
'fd-bar--cozy': !compact,
'fd-bar--compact': compact
}
);
Expand Down Expand Up @@ -408,7 +408,7 @@ class DatePicker extends Component {
<Button {...buttonProps}
aria-label={buttonLabel}
disabled={disableButton}
glyph='calendar'
glyph='appointment-2'
onClick={this.handleClickButton}
option='transparent' />
</InputGroup.Addon>
Expand Down
24 changes: 12 additions & 12 deletions src/DatePicker/DatePicker.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ describe('<DatePicker />', () => {
type: 'select',
label: 'Today'
}} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
const todayButtonWrapper = wrapper.find('button.fd-dialog__decisive-button');
expect(todayButtonWrapper.exists()).toBe(true);
expect(todayButtonWrapper.getDOMNode().innerHTML).toBe('Today');
Expand All @@ -324,7 +324,7 @@ describe('<DatePicker />', () => {
type: 'select',
label: 'Today'
}} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
const todayButtonWrapper = wrapper.find('button.fd-dialog__decisive-button');
expect(todayButtonWrapper.exists()).toBe(false);
});
Expand All @@ -336,7 +336,7 @@ describe('<DatePicker />', () => {
type: 'select',
label: 'Today'
}} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
const todayButtonWrapper = wrapper.find('button.fd-dialog__decisive-button');
expect(todayButtonWrapper.exists()).toBe(true);
todayButtonWrapper.simulate('click');
Expand All @@ -353,7 +353,7 @@ describe('<DatePicker />', () => {
type: 'select',
label: 'Today'
}} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
const todayButtonWrapper = wrapper.find('button.fd-dialog__decisive-button');
todayButtonWrapper.simulate('click');
expect(change).toHaveBeenCalledWith(expect.objectContaining({ formattedDate: moment().format('YYYY/MM/DD') }));
Expand Down Expand Up @@ -404,7 +404,7 @@ describe('<DatePicker />', () => {
const datePickerClose = jest.fn();
const element = mount(<DatePicker dateFormat='YYYY-MM-DD' defaultValue='2020-03-13'
onDatePickerClose={datePickerClose} />);
element.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
element.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
element.find('.fd-calendar__text').at(8).simulate('click');
expect(datePickerClose).toHaveBeenCalledWith(expect.objectContaining({ formattedDate: '2020-03-02' }));
expect(datePickerClose).toHaveBeenCalledTimes(1);
Expand Down Expand Up @@ -463,7 +463,7 @@ describe('<DatePicker />', () => {
element = element.setProps({
dateFormat: 'MM/DD/YYYY'
});
element.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
element.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
element.find('.fd-calendar__text').at(8).simulate('click');

expect(change).toHaveBeenCalledWith(expect.objectContaining({ formattedDate: '03/02/2020' }));
Expand Down Expand Up @@ -508,7 +508,7 @@ describe('<DatePicker />', () => {
const element = mount(<DatePicker buttonProps={{ 'data-sample': 'Sample' }} />);

expect(
element.find('button.fd-button--transparent.sap-icon--calendar').getDOMNode().attributes['data-sample'].value
element.find('button.fd-button--transparent.sap-icon--appointment-2').getDOMNode().attributes['data-sample'].value
).toBe('Sample');
});

Expand All @@ -519,7 +519,7 @@ describe('<DatePicker />', () => {
}
};
wrapper = mount(<DatePicker calendarProps={calendarProps} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
wrapper.find('.fd-calendar__action').at(1).childAt(0).simulate('click');

expect(
Expand All @@ -534,7 +534,7 @@ describe('<DatePicker />', () => {
}
};
wrapper = mount(<DatePicker calendarProps={calendarProps} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');
wrapper.find('.fd-calendar__action').at(2).childAt(0).simulate('click');

expect(
Expand All @@ -549,7 +549,7 @@ describe('<DatePicker />', () => {
}
};
wrapper = mount(<DatePicker calendarProps={calendarProps} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');

expect(
wrapper.find('.fd-calendar__dates').childAt(0).getDOMNode().attributes['data-sample'].value
Expand All @@ -563,7 +563,7 @@ describe('<DatePicker />', () => {
}
};
wrapper = mount(<DatePicker calendarProps={calendarProps} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');

expect(
wrapper.find('.fd-calendar__group').at(0).getDOMNode().attributes['data-sample'].value
Expand All @@ -577,7 +577,7 @@ describe('<DatePicker />', () => {
}
};
wrapper = mount(<DatePicker calendarProps={calendarProps} />);
wrapper.find('button.fd-button--transparent.sap-icon--calendar').simulate('click');
wrapper.find('button.fd-button--transparent.sap-icon--appointment-2').simulate('click');

expect(
wrapper.find('tbody').getDOMNode().attributes['data-sample'].value
Expand Down
Loading

0 comments on commit 695aac4

Please sign in to comment.