Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal does not contain Focus Cycling mechanism #345

Closed
jeffredodd opened this issue Feb 1, 2019 · 0 comments · Fixed by #349
Closed

Modal does not contain Focus Cycling mechanism #345

jeffredodd opened this issue Feb 1, 2019 · 0 comments · Fixed by #349

Comments

@jeffredodd
Copy link
Contributor

jeffredodd commented Feb 1, 2019

Description

In order to be WCAG 2.1 compliant, our Modal's with the role='dialog' must contain a mechanism to enforce focus cycling. A users focus must be contained within a modal to be compliant. See https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal for more information.

Reproduction

  1. Open a modal
  2. Attempt to tab

Expected:

  • Focus should remain within modal
  • Focus should be redirected into modal when opened

Actual:

  • Focus is not altered and left in last known state.

Note: This issue is seen in all 3 libraries
Fundamental-React: #345
Fundamental-NGX: SAP/fundamental-ngx#477
Fundamental-Vue: SAP/fundamental-vue#136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant