feat: Substring Search in SearchInput #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for fundamental-react ready! Built with commit 9fa1ed5 |
jbadan
reviewed
Jun 23, 2020
prsdthkr
requested changes
Jun 25, 2020
jbadan
reviewed
Jun 25, 2020
jbadan
approved these changes
Jun 30, 2020
prsdthkr
approved these changes
Jul 1, 2020
|
I had to revert this as it was causing lots of failures in ci - I'm wondering if it needed to be updated with master? |
|
@muthukkaruppan4695 Can you reopen the pull request? I can't do it in on your behalf |
skvale
reviewed
Jul 8, 2020
| @@ -231,6 +241,8 @@ SearchInput.propTypes = { | |||
| callback: PropTypes.func | |||
| }) | |||
| ), | |||
| /** enable substring search */ | |||
| subStringSearch: PropTypes.bool, | |||
There was a problem hiding this comment.
What do you think about keeping the capitalization consistent with JavaScript's substring method?
subStringSearch -> substringSearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1003
fixes #1003