feat: Use the popperPlacement prop to allow fallbackPlacements #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit e5acf75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This came up as an improved way to implement fallback placements for popper components. Basically the popperPlacement prop can be a single string and utilize Popper's default of flipping to the opposite placement
i.e. "bottom-end" would flip to "top-end" by default
or they can specify an array of placements to use.
popperPlacement={['bottom-end', 'right', 'top']}This needed to be implemented to better support flip containers, DOM elements which the popper should stay within, in this PR #1122.
NOTE: The exposed
fallbackPlacementsprop has only been in an rc release, so it's not a breaking change outside of the current rcfixes #issueid