fix: allow custom modal manager for DatePicker #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit bb4c1d0 |
jacobdevera
approved these changes
Jul 30, 2020
skvale
reviewed
Jul 31, 2020
| @@ -364,6 +364,7 @@ class DatePicker extends Component { | |||
| todayAction, | |||
| validationState, | |||
| weekdayStart, | |||
| modalManager, | |||
There was a problem hiding this comment.
We could add this to the propTypes for DatePicker as well
/** If DatePicker is to be rendered in a modal, the parent modal manager can be passed as a prop */
modalManager: PropTypes.object,
skvale
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a DatePicker component is included in a modal, pressing escape will close both the DatePicker and modal as they have different modal managers. This PR allows for a custom modal manager to be passed down from a parent component.