fix: MessageStrip Accessibility + useUniqueId hook #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit e0d923d |
jbadan
reviewed
Aug 10, 2020
src/MessageStrip/MessageStrip.js
Outdated
| @@ -47,17 +48,20 @@ const MessageStrip = (props) => { | |||
| className | |||
| ); | |||
|
|
|||
| const alertId = otherProps?.id || shortId.generate(); | |||
There was a problem hiding this comment.
Can we create a useUniqueId() hook like in widgets -
import shortid from './shortId';
import { useState } from 'react';
export default () => {
const [uniqueId, setUniqueId] = useState();
if (uniqueId) return uniqueId;
const id = shortid.generate();
setUniqueId(id);
return id;
};
skvale
reviewed
Aug 10, 2020
src/MessageStrip/MessageStrip.js
Outdated
| @@ -48,10 +48,10 @@ const MessageStrip = (props) => { | |||
| className | |||
| ); | |||
|
|
|||
| const alertId = otherProps?.id || shortId.generate(); | |||
| const alertId = otherProps?.id || useUniqueId(); | |||
There was a problem hiding this comment.
We can't conditionally call hooks like this, or with ternary expressions like others.
We can split it onto separate lines though,
const generatedId = useUniqueId();
const alertId = otherProps?.id || generatedId;
prsdthkr
changed the title
skvale
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this change, we
aria-controlsvalue for theMessageStripclose buttonuseUniqueIdhook to generate IDs in functional componentsfixes #1153
Before
After
Know Issues
https://github.com/SAP/fundamental-react/issues/1155