fix: Move SearchInput and SideNav callbacks outside of setState. #1165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the callback with an event is included in the callback of setState the event is not persisted and we lose the event.target
You will see warnings like this:
BREAKING_CHANGE: If consumers had used the SearchInput like the test, where it was expecting the input's ref value to be updated inside of the callback, this is a breaking change, but that seems like a non-react way to handle changes
fixes #629