feat: update fundamental-styles to v0.12.0-rc.18 #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsdthkr
added
the
update fundamental styles
prsdthkr
changed the title
|
Deploy preview for fundamental-react ready! Built with commit 8f48459 |
prsdthkr
changed the title
|
Re: treeview - let's just delete it. |
jbadan
reviewed
Aug 26, 2020
| import React, { useState, useEffect } from 'react'; | ||
| import Button from '../../../src/Button/Button'; | ||
|
|
||
| const CopyButton = ({ copyText }) => { |
jbadan
reviewed
Aug 26, 2020
| return ( | ||
| <> | ||
| <Header /> | ||
| <Title /> | ||
| <Toc /> | ||
| <Subtitle /> | ||
| {context?.parameters?.deprecated && <Description desc={context?.parameters?.deprecated} />} | ||
| {!context?.parameters?.noImport && showImport()} | ||
| {context?.parameters?.displaySubComponentImports && showSubImports()} | ||
| {context?.parameters?.description && <Description desc={context?.parameters?.description} />} |
There was a problem hiding this comment.
Not caused by this pr (it's in master too) - but our descriptions are gone 😢
There was a problem hiding this comment.
I can see the description for our Tree component here: https://deploy-preview-1172--fundamental-react.netlify.app/?path=/docs/component-api-tree--wrapping-and-non-wrapping-contents
Edit: I just realized what you meant. I know how to fix this.
There was a problem hiding this comment.
I got the story descriptions working here, but not the component descriptions: #1189
# Conflicts: # package.json
jacobdevera
approved these changes
Aug 27, 2020
meganaconley
approved these changes
Aug 27, 2020
|
Closing and reopening to trigger checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE:
In this change we
fundamental-stylesto0.12.0-rc.18and support the new features and fixes therein.LayoutGridcomponent in favor of the new grid system based onContainer,Row, andColumncomponentsLayoutPanel.colSpanproperty. Added story forLayoutPanelin the new grid system.TreeViewcomponent in favor of the newTreecomponent.Question
TreeViewstyles are broken and I've marked it as deprecated. Do we want to remove it entirely instead?Yes
Fixes #646 #310