Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional props for customization to validationOverlayProps #1192

Merged
merged 2 commits into from
Sep 1, 2020
Merged

feat: add additional props for customization to validationOverlayProps #1192

merged 2 commits into from
Sep 1, 2020

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Aug 28, 2020

Description

I want to be able to add a custom class to the Popper in FormMessage from any component consuming it.

Additionally added documentation + tests for validationOverlayProps.wrapperProps

Added tests

Continuation of #1185

fixes #issueid

@netlify
Copy link

netlify bot commented Aug 28, 2020 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit de768e3

https://deploy-preview-1192--fundamental-react.netlify.app

@jacobdevera
Copy link
Contributor

jacobdevera commented Aug 28, 2020 •
edited
Loading

I'm assuming these will also need formMessageProps

  • ComboboxInput
  • DatePicker
  • MultiInput

And DatePicker might need a way to pass props to the InputGroup

@jbadan
Copy link
Contributor Author

jbadan commented Aug 31, 2020 •
edited
Loading

@jacobdevera I'd prefer to handle all the components using InputGroup in a separate pr

Edit: More I think about it, you're right. It belongs in this pr

@jbadan jbadan requested a review from a team August 31, 2020 15:29
skvale
skvale approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@skvale skvale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbadan jbadan merged commit ebbbd31 into master Sep 1, 2020
@jbadan jbadan deleted the formmessage branch September 1, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skvale skvale skvale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbadan @jacobdevera @skvale