Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: datepicker improvements #1224

Merged
merged 5 commits into from
Sep 28, 2020
Merged

feat: datepicker improvements #1224

merged 5 commits into from
Sep 28, 2020

Conversation

prsdthkr
Copy link
Member

Description

In this change, we update the Datepicker

  • to accept and set a defaultValue when enableRangeSelection is set. For example, defaultValue='01/01/2019 - 01/01/2020'
  • add story for above use case
  • to allow spreading props into the <InputGroup.Addon>, footer, and footer <Button>

GIF

fd-react-datepicker-range-default

@prsdthkr prsdthkr self-assigned this Sep 26, 2020
@netlify
Copy link

netlify bot commented Sep 26, 2020 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit 425ef57

https://deploy-preview-1224--fundamental-react.netlify.app

@prsdthkr prsdthkr marked this pull request as ready for review September 26, 2020 03:16
@prsdthkr prsdthkr requested a review from a team September 26, 2020 03:16
jbadan
jbadan approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@prsdthkr prsdthkr merged commit 5d71ff0 into master Sep 28, 2020
@prsdthkr prsdthkr deleted the feat/datepicker-improvements branch September 28, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees

@prsdthkr prsdthkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prsdthkr @jbadan