-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Hide the DatePicker button when readOnly is true #1234
feat: Hide the DatePicker button when readOnly is true #1234
Conversation
Deploy preview for fundamental-react ready! Built with commit fd4af75 |
I hate to make this change more complicated, but do we need to do this in fundamental styles too? Edit: there is no readOnly example in fundamental-styles, so we're safe to proceed here. |
I came here to ask about this too: I see it is not documented there, but what is the Fiori3 stance on what readonly fields should look like? |
@bcullman It's not defined anywhere in the spec - DatePicker documentation mostly centers around the Calendar in the popover with very little about the actual input field. |
Are we OK merging this and picking that up as a conversation in a Thursday meeting? |
if it's not documented, why do we think the solution is to hide the add-ons? I get that this is A possible solution, but I am not certain it is the right one. We need someone from UX to weigh in/followup on this |
We talked with Brandon and he thought it made sense to go with this change as it currently is. |
Description
A readOnly DatePicker field should not have a button
Breaking Change: A readOnly DatePicker field does not have an InputGroup Button
IE11
![Screen Shot 2020-10-06 at 8 46 22 AM](https://user-images.githubusercontent.com/5314713/95209925-84e26480-07b0-11eb-99f8-02cd8b648ee0.png)