fix: InputGroup validation changes #1260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE
Refactor
_FormValidationOverlay
inInputGroup
and related componentsInputGroup
will now always render with a_FormValidationOverlay
regardless of whether a validation state is present or not. This prevents the component from throwing away the oldinput
element and losing the previous state when the validation state changes.ComboboxInput
that makes it impossible to enter inputDatePicker
that would cause it to lose focus when closing theCalendar
with theEsc
key_FormValidationOverlay
iftext
is present invalidationState
with a valid stringvalidationOverlayProps
fromSearchInput
as this would now be handled by passing them intoinputGroupProps
formMessageProps
toSearchInput
to handle passing props into its ownFormMessage
fixes #1207