Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InputGroup validation changes #1260

Merged
merged 7 commits into from
Nov 9, 2020
Merged

Conversation

jacobdevera
Copy link
Contributor

@jacobdevera jacobdevera commented Nov 6, 2020

Description

BREAKING CHANGE
Refactor _FormValidationOverlay in InputGroup and related components

  • InputGroup will now always render with a _FormValidationOverlay regardless of whether a validation state is present or not. This prevents the component from throwing away the old input element and losing the previous state when the validation state changes.
    • fixes an issue with ComboboxInput that makes it impossible to enter input
    • fixes an issue with DatePicker that would cause it to lose focus when closing the Calendar with the Esc key
  • only show _FormValidationOverlay if text is present in validationState with a valid string
  • remove validationOverlayProps from SearchInput as this would now be handled by passing them into inputGroupProps
  • add formMessageProps to SearchInput to handle passing props into its own FormMessage

fixes #1207

@jacobdevera jacobdevera self-assigned this Nov 6, 2020
@netlify
Copy link

netlify bot commented Nov 6, 2020

Deploy preview for fundamental-react ready!

Built with commit d3126ea

https://deploy-preview-1260--fundamental-react.netlify.app

Copy link
Contributor

@meganaconley meganaconley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, inputs no longer lose focus after validation.

@jacobdevera jacobdevera merged commit 83f3c7c into master Nov 9, 2020
@jacobdevera jacobdevera deleted the fix/inputgroup-validation branch November 9, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox with validation states is broken
3 participants