feat: update fundamental-styles to 0.13.1-rc.2 #1266
Conversation
|
Deploy preview for fundamental-react ready! Built with commit 3f3d9d1 |
| <Button | ||
| aria-label='Pie chart' | ||
| glyph='pie-chart' | ||
| selected /> |
There was a problem hiding this comment.
It was removed as an attribute of the underlying <button> but not as a prop. It still is used to apply a classname.
| <a | ||
| className={classnames(`${cssNamespace}-breadcrumb__link`)} | ||
| href={url} | ||
| tabIndex='0'> |
There was a problem hiding this comment.
Is there a reason we need to explicitly set a tabindex for an a?
EDIT: never mind, it's inside the <li> with the negative tabindex, disregard
There was a problem hiding this comment.
Removing it seems to still work, but I think it's safest to keep it in case there are some browser/screen reader combos that might not tab to these links.
This reverts commit 970a9f4.
| disabled | ||
| options={options} | ||
| placeholder='Select' /> | ||
| ); | ||
| export const readOnly = () => ( | ||
| <Select | ||
| aria-label='readOnly' |
There was a problem hiding this comment.
Wasn't sure how the screen reader would sound with the concatenated word readOnly but it sounds no different than if it were "Read Only" 👍
BREAKING CHANGE
Description
This update includes:
Buttonno longer hasselectedattributeTabaria attributes and role moved from theato theliBreadcrumbandrole="menu"addedaria-labelsfor icons