fix: Only export components when publishing #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadan
previously requested changes
Jan 11, 2019
|
Also I'm up for a name thats different from |
There was a problem hiding this comment.
A few things:
- I am still seeing the
documentationdirectory show up indist. Should it be? - If we are going to isolate the playground from the other
srcdirectories, I would prefer aplaygrounddirectory at the root rather than a_playgrounddirectory withinsrc. Just my opinion. - In the
src/index.jsfile, it is importingreactandreact-dom, but I don't believe it needs to be. - In the
src/index.jsfile, I am wondering if this file should be refactored so each line is the import AND export to make it more readable. Example:
export {Alert} from '../src/Alert/Alert';
added 3 commits
January 14, 2019 10:22
|
Hey @greg-a-smith! |
greg-a-smith
suggested changes
Jan 15, 2019
src/index.js
Outdated
|
|
||
| ReactDOM.render(<App />, document.getElementById('root')); | ||
| registerServiceWorker(); | ||
| export { ActionBar } from '../src/ActionBar/ActionBar'; |
There was a problem hiding this comment.
I think all of these should be rewritten to NOT include the src directory as I am still seeing the src directory in the path in the dist directory.
So:
export { ActionBar } from '../src/ActionBar/ActionBar';
should become:
export { ActionBar } from './ActionBar/ActionBar';
|
I spoke with @jeffredodd, who is out sick, about taking over this PR to get it merged. |
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Initial change to only export library * Remove documentation folder from Components * Remove react and react-dom from component exports * Updating index.js file to contain individual exports * Quick fix to src src-ing * Changed the jest coverage ignore path of the playground components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone, the goal of this PR is to only publish our components to
npmand to leave the tests, component documentation, and other CreateReactApp leftovers behind. This will reduce the payload we send to consumers and simply our outputted package while leaving the structure mostly intact to allow for simple contributions and also resolves #105.I have performed the following...
_playground_playgroundfolderindex.jsfile to no longer have documentation site componentsRoutes.jsto point to existing components correctlyFeel free to pull this down and test the changes i've made and let me know what you think. It might help to poke around on
master'sdistfolder first to see what was omitted in this branch.This branch also should not go in until publishing on
masteris fixed.