Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update link in readme for contributing guidelines #216

Merged
merged 2 commits into from
Jan 16, 2019
Merged

fix: update link in readme for contributing guidelines #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9039a0
update contributing readme link
jbadan Jan 16, 2019
cca30b9
move unit-testing.md to wiki
jbadan Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ You must follow the coding style as best you can when submitting code. Take note

### Unit testing

All components should have associated unit tests created with a code coverage score of at least 85%. Be an overachiever and shoot for 100% :) [Learn how to create unit tests](./UNIT-TESTING.md)
All components should have associated unit tests created with a code coverage score of at least 85%. Be an overachiever and shoot for 100% :) [Learn how to create unit tests](https://github.com/SAP/fundamental-react/wiki/Unit-Testing)

### How to contribute - the Process

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ If you encounter an issue or want to request a feature, you can [create an issue

## Contributing

If you want to contribute, please check the [Contribution Guidelines](./CONTRIBUTING.md).
If you want to contribute, please check the [Contribution Guidelines](./.github/CONTRIBUTING.md).

## License

Copyright (c) 2018 SAP SE or an SAP affiliate company. All rights reserved.
Copyright (c) 2019 SAP SE or an SAP affiliate company. All rights reserved.
This library is licensed under the Apache Software License, v. 2 except as noted otherwise in the [License File](https://github.com/SAP/fundamental-react/blob/master/LICENSE.txt).

## Similar Projects
Expand Down
50 changes: 0 additions & 50 deletions UNIT-TESTING.md
View file
Open in desktop

This file was deleted.