-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to fundamental-styles 0.2.0 #742
Conversation
Deploy preview for fundamental-react ready! Built with commit 7b7a89e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a partial collection of comments from the first files down through Dropdown
. More to come, but trying to keep the review moving.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another Herculean effort 💪 @jbadan! There are a few minor things I found here and there, but let's get this PR merged and do some smaller-scoped follow-up work to address those. I will add my findings to the wiki pages already created.
Description
KNOWN ISSUES out of scope of this pr:
Time
Shellbar SearchInput
is open always - we need to rewrite a ton of logic to get this to be hidden smoothly.[BREAKING CHANGE]
Infrastructure
Components
Changes besides classnames listed here: https://github.com/SAP/fundamental-styles/wiki/Breaking-Changes
ActionBar
mobile
,width
propsButton
dropdown
,navbar
propsfd-dropdown__control
,fd-global-nav__btn
classesCalendar
fd-button--standard
class from buttonsComboBoxInput
fd-combobox-control
class +div
FormItem
fd-form-item--check
isCheck
propFormItem
checkbox withCheckbox
componentInputGroup
SearchInput
searchButtonProps
propListGroupItemCheckbox
MenuItem
separator
prop (now lives inMenuList
)Modal
div
around actionsMultiInput
div
around popover controlSearchInput
searchList
prop propTypes is more explicit - requires array of objects with keys includingtext
(required) andcallback
Shellbar
div
sTile
rowSpan
,columnSpan
(handled inLayoutGrid
)colorAccent
,backgroundColor
(handled by helper classes)TimePicker
div
Removed Components:
PanelGrid
TileGrid
New Components:
Checkbox
Link
LayoutGrid
fixes #issueid