Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated unit test coverage and eslint warnings #76

Merged
merged 1 commit into from
Nov 21, 2018
Merged

updated unit test coverage and eslint warnings #76

merged 1 commit into from
Nov 21, 2018

Conversation

chrismanciero
Copy link
Contributor

issue #30

  • Identifier & image components, removed if check for size, since size is a required field
  • Removed duplicate prop in Popover component for ref
  • Updated Tabs component to fix eslint warning

CodesOfRa
CodesOfRa approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@CodesOfRa CodesOfRa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrismanciero chrismanciero merged commit 528bc9c into develop Nov 21, 2018
@chrismanciero chrismanciero deleted the unit-test-cleanup branch November 21, 2018 21:11
droshev added a commit that referenced this pull request Dec 14, 2018
@droshev
#76 make unit-tests.sh executable
6a5bd16
greg-a-smith pushed a commit that referenced this pull request Mar 5, 2019
@droshev
#76 make unit-tests.sh executable
c48e398
greg-a-smith pushed a commit that referenced this pull request Mar 5, 2019
@chrismanciero
Merge pull request #76 from SAP/unit-test-cleanup
f575a9b 
updated unit test coverage and eslint warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodesOfRa CodesOfRa CodesOfRa approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrismanciero @CodesOfRa @InnaAtanasova