New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor input group #767
Merged
+433
−730
Merged
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5e3e556
initial refactor
hertweckhr1 80a2e87
InputGroup.Addon and InputGroup.Input
hertweckhr1 2aeb2fc
tests and storybook examples
hertweckhr1 fad770e
round 1 changes
hertweckhr1 ca06ff9
round 2 no actions, added isButton
hertweckhr1 bdb1021
clean up children
hertweckhr1 86cd014
iteration on storybook
hertweckhr1 3fa0287
no isbutton bool in stories
hertweckhr1 fa478fa
quick nit fix
hertweckhr1 be61c76
get rid of inputgroup.input
hertweckhr1 c5f5971
delete custom and disable style reference
hertweckhr1 ea6d442
displayname, fix children on test, edit component page
hertweckhr1 b7d5fb9
added test
hertweckhr1 01a2fff
pass fd-input-group__button to button children
hertweckhr1 fd6f3f1
round 4 delete unneeded --compact classnames
hertweckhr1 00d78b3
merge with master
hertweckhr1 4e43379
round 5, no compact in button, correct matching for child.type.displa…
hertweckhr1 e7604cd
remove hardcoded displayName
hertweckhr1 827119a
added test for isButton
hertweckhr1 67df3b7
compact inputaddon snapshot added
hertweckhr1 6346ab4
fixed snapshot for addon with button
hertweckhr1 8ad745c
spelling nit
hertweckhr1 d4e291c
edit tests
hertweckhr1 25c16d1
delete child.type throw error test
hertweckhr1 0a8b751
nit on test
hertweckhr1 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate weird abbreviations anyway! 🎉