feat: Move FormGroup to forms #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 171e3fd |
|
Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-react/deploys Built with commit e85db4d https://app.netlify.com/sites/fundamental-react/deploys/5da64e95b94bbd000aa6aaff |
| @@ -1,7 +1,7 @@ | |||
| import FormGroup from '../FormGroup'; | |||
| import FormItem from '../../Forms/FormItem'; | |||
| import FormLabel from '../../Forms/FormLabel'; | |||
There was a problem hiding this comment.
Minor nit: both FormItem and FormLabel could have paths simplified to ../FormItem or ../FormLabel, respectively.
bcullman
reviewed
Oct 16, 2019
src/index.js
Outdated
| @@ -28,7 +28,7 @@ export { default as Identifier } from './Identifier/Identifier'; | |||
| export { default as Image } from './Image/Image'; | |||
| export { default as InlineHelp } from './InlineHelp/InlineHelp'; | |||
| export { default as InputGroup } from './InputGroup/InputGroup'; | |||
| export { default as FormGroup } from './InputGroup/FormGroup'; | |||
| export { default as FormGroup } from './Forms/FormGroup'; | |||
There was a problem hiding this comment.
Probably worth reordering this list by alpha - it will put FormGroup up by the other Form* exports.
greg-a-smith
changed the title
hertweckhr1
commented
Oct 16, 2019
| @@ -16,42 +16,42 @@ export const FormsComponent = () => { | |||
| and noted by an asterisk (*).`} | |||
| title='Inputs'> | |||
| <div> | |||
| <FormSet> | |||
| <FormGroup> | |||
There was a problem hiding this comment.
Added FormGroup to an example so that we are using FormGroup in the Forms page
hertweckhr1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE
As a side story to the breaking change we're making by refactoring inputgroup -> moving over FormGroup to Forms instead of InputGroup.
Used git mv in order to preserve git history.