fix: No Popover Arrow #790
Conversation
* additional refactoring
prsdthkr
requested review from
greg-a-smith and
jbadan
and removed request for
greg-a-smith
|
|
|
Prasad Thakur seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
prsdthkr
added
bug
|
Deploy preview for fundamental-react ready! Built with commit 17a0ca0 |
| placement='left-start' | ||
| style={{ position: 'fixed', top: '15em', left: '40em' }} /> | ||
| </> | ||
| )) |
There was a problem hiding this comment.
Since you're making examples of each placement, we should probably also add top-start, top-end, bottom-start and bottom-end.
There was a problem hiding this comment.
Done. IDK how I missed these. Thanks!
prsdthkr
force-pushed
the
fix/no-popover-arrow
branch
from
b65f166
to
b9c6008
Compare
| body={someText} | ||
| control={<Button glyph='navigation-up-arrow' option='light' >Pop to Top-Start</Button>} | ||
| placement='top-start' | ||
| style={{ position: 'fixed', top: '10em', left: '35em' }} /> |
There was a problem hiding this comment.
The placement style for each of these is strange. When I have the inspector open, I am not seeing the bottom row and no scrollbar appears. How about building a table that is centered?
| Layout | ||||
|---|---|---|---|---|
| Top Start | Top | Top End | ||
| Left Start | Right Start | |||
| Left | Right | |||
| Left End | Right End | |||
| Bottom Start | Bottom | Bottom End |
Description
Cause: Mismatch between FD-style expected attribute name and FD-react property applied leading to appropriate styles not being applied to the popover.
Solution: Change popover
<div>'s property names to match FD-style attribute selectors seen here.data-placementbecomesx-placementdata-x-out-of-boundariesbecomesx-out-of-boundariesBefore (chrome)
After (chrome)
fixes #740