Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme bundled CSS #2837

Closed
jasssonpet opened this issue Oct 20, 2021 · 1 comment · Fixed by #2875
Closed

Dark theme bundled CSS #2837

jasssonpet opened this issue Oct 20, 2021 · 1 comment · Fixed by #2875
Assignees
@droshev
Labels
Bug Something isn't working Theming
Projects
Development
Milestone
Sprint 74 - Longu...

Comments

@jasssonpet
Copy link

jasssonpet commented Oct 20, 2021 •
edited

Describe the bug

Hello, it looks like the dark theme distribution is the (almost) the same as the white theme:

It looks like that only separated CSS component files have the dark theme but not the bundled one (fundamental-styles-sap_fiori_3_dark.css).

This is also the same in the NPM distribution (0.20).
@droshev droshev added Bug Something isn't working Theming labels Oct 31, 2021
droshev added a commit that referenced this issue Oct 31, 2021
@droshev
fix(styles): fix dark theme bundled CSS #2837
b7e1942
droshev added a commit that referenced this issue Oct 31, 2021
@droshev
fix(styles): dark, hcb, hcw bundled CSS to contain the right colors #…
6851818 
…2837
@droshev droshev mentioned this issue Oct 31, 2021
Merged
2 tasks
droshev added a commit that referenced this issue Oct 31, 2021
@droshev
fix(styles): dark, hcb, hcw bundled CSS to contain the right colors #…
b827648 
…2837 [ci visual]
@droshev
Copy link
Contributor

droshev commented Oct 31, 2021

@jasssonpet thank you for reporting the issue. I have opened a PR (#2875 )

@droshev droshev self-assigned this Oct 31, 2021
@droshev droshev added this to the Sprint 74 - Longueuil milestone Oct 31, 2021
droshev added a commit that referenced this issue Nov 1, 2021
@droshev
fix(styles): dark, hcb, hcw bundled CSS to contain the right colors #…
73ef574 
…2837 [ci visual] (#2875)

BREAKING CHANGE:
remove variables.css, variables-sap_fiori_3*.css files from dist folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droshev droshev

Labels
Bug Something isn't working Theming
Projects
Development
  
Awaiting triage
Milestone
Sprint 74 - Longueuil
Development

Successfully merging a pull request may close this issue.

fix(styles): dark, hcb, hcw bundled CSS to contain the right colors SAP/fundamental-styles
2 participants
@jasssonpet @droshev