Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add calendar to storybook #1140

Merged
merged 8 commits into from
Jun 11, 2020
Merged

chore: add calendar to storybook #1140

merged 8 commits into from
Jun 11, 2020

Conversation

prsdthkr
Copy link
Member

@prsdthkr prsdthkr commented Jun 10, 2020 •
edited

  • Add calendar component
    • stories
    • documentation
    • visual tests
  • remove old njk tests and visual snapshots

screencapture-localhost-6006-2020-06-09-19_41_53

@prsdthkr prsdthkr requested a review from a team June 10, 2020 02:45
@prsdthkr prsdthkr self-assigned this Jun 10, 2020
@netlify
Copy link

netlify bot commented Jun 10, 2020 •
edited

Deploy preview for fundamental-styles ready!

Built with commit faf10f7

https://deploy-preview-1140--fundamental-styles.netlify.app

@prsdthkr prsdthkr mentioned this pull request Jun 10, 2020
Merged
1 task
InnaAtanasova
InnaAtanasova reviewed Jun 11, 2020
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the <li><a href="calendar">.fd-calendar</a></li> from test/templates/index.njk file. The rest looks good. Great job with this component!

@prsdthkr
Copy link
Member Author

Thanks @InnaAtanasova, i've made that change.

@InnaAtanasova InnaAtanasova added this to PRs Reviewer approved in Development via automation Jun 11, 2020
@prsdthkr prsdthkr merged commit ab16fe8 into master Jun 11, 2020
Development automation moved this from PRs Reviewer approved to Done Jun 11, 2020
@prsdthkr prsdthkr deleted the chore/calendar-to-storybook branch June 11, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@droshev droshev Awaiting requested review from droshev

Assignees

@prsdthkr prsdthkr

Labels
storybook
Projects
Development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prsdthkr @InnaAtanasova